AMaViS patch to prevent cleanup errors and spurious messages

Version 1.0, 13 Feb 2004
Rick Jones, Active Service Consulting Ltd, UK


Introduction:

This patch applies to amavis-ng 1.6.4, as provided for SME server
by Jesper Knudsen at http://sme.swerts-knudsen.dk


Problems:

I noticed after installing this version of amavis that the working
directories were not always being cleaned up. These rogue directories
corresponded to the following logged messages -

"AMAVIS::MTA::Qmail: Wrong recipient line format"
"Error: Couldn't get directory for extracting"

Any corresponding message got completely black-holed.

The problem is down to an error in the logic sequence in Qmail.pm,
and a wrong assumption about cause of failure in AMAVIS.pm

It turns out that the emails causing these problems are
undeliverable, and usually empty. My guess it that they result
from aborted incoming SMTP sessions, but I didn't dig back that
far to confirm the theory.


Fix:

The enclosed patch file amavis-qmail.pat will patch the two Perl
scripts involved. Copy it to /usr/lib/perl5/site_perl/5.6.1, then
cd to that directory and run:

patch -b -p1 <amavis-qmail.pat


Changes:

As well as ensuring that temporary directories are cleaned up,
the logged message for "Wrong recipient line format" includes
the actual recipient line in parentheses at the end. In every
occurrence I've seen the line is empty (hence can't be processed).

An additional info message is logged: "Abandoning message",
indicating that any message is being thrown away. This was
what happened before, but nothing was logged to say so.

Another minor but unrelated fix is that the log message:
"AMAVIS::MTA::Qmail: qmail-queue exited 0"
is now classed as an INFO message rather than ERR.
This is a normal condition, so with log level at INFO (4)
it prevents the item being pointlessly logged.



Rick Jones
rick@activeservice.co.uk